Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 11411119: Clean up warnings. (Closed)

Created:
8 years, 1 month ago by karlklose
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +1 line, -1 line 2 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +7 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 1 chunk +2 lines, -1 line 3 comments Download

Messages

Total messages: 5 (0 generated)
karlklose
8 years, 1 month ago (2012-11-21 10:09:39 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1181 sdk/lib/_internal/compiler/implementation/elements/elements.dart:1181: var target = defaultImplementation; I can't find which ...
8 years, 1 month ago (2012-11-21 10:22:11 UTC) #2
Johnni Winther
lgtm
8 years, 1 month ago (2012-11-21 11:01:26 UTC) #3
karlklose
Thanks, Nicolas! https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1181 sdk/lib/_internal/compiler/implementation/elements/elements.dart:1181: var target = defaultImplementation; target.defaultImplementation in the ...
8 years, 1 month ago (2012-11-21 11:33:32 UTC) #4
ahe
8 years, 1 month ago (2012-11-22 16:11:30 UTC) #5
LGTM!

https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:438:
ClassElement classySelf = self;
LOL!

Powered by Google App Engine
This is Rietveld 408576698