sdk/lib/_internal/compiler/implementation/scanner/token.dart - Issue 11411092: Revert "Add some support for the code-point code-unit distinction."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/token.dart

Issue 11411092: Revert "Add some support for the code-point code-unit distinction." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_string.dart ('k') | sdk/lib/_internal/compiler/implementation/source_map_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/scanner/token.dart

diff --git a/sdk/lib/_internal/compiler/implementation/scanner/token.dart b/sdk/lib/_internal/compiler/implementation/scanner/token.dart

index 79b63c1d760daa3eb6ab6e2cb687b3ad710e21a0..a768b5038458be91960883793ce175f69e29d55d 100644

--- a/sdk/lib/_internal/compiler/implementation/scanner/token.dart

+++ b/sdk/lib/_internal/compiler/implementation/scanner/token.dart

@@ -231,9 +231,6 @@ class StringWrapper implements SourceString {

bool isPrivate() => !isEmpty && identical(stringValue.charCodeAt(0), $_);

}

-// TODO(erikcorry): Use the new code point iterator on String when it is

-// available.

class StringCodeIterator implements Iterator<int> {

final String string;

int index;

@@ -249,12 +246,7 @@ class StringCodeIterator implements Iterator<int> {

}

bool get hasNext => index < end;

- int next() {

- int charCode = string.charCodeAt(index++);

- // Skip trail surrogate.

- if (charCode >= String.SUPPLEMENTARY_CODE_POINT_BASE) index++;

- return charCode;

- }

+ int next() => string.charCodeAt(index++);

}

class BeginGroupToken extends StringToken {