Issue 11411059: overscroll-aura: Discard synthetic mouse-move events during a trackpad overscroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411059: overscroll-aura: Discard synthetic mouse-move events during a trackpad overscroll. (Closed)

Created:
8 years, 1 month ago by sadrul

Modified:
8 years, 1 month ago

Reviewers:
DaveMoore, sky

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

overscroll-aura: Discard synthetic mouse-move events during a trackpad overscroll. As the overscroll is handled during scroll events from the trackpad, the RWHVA window is transformed. This transform triggers a synthetic mouse-move event to be generated (by the aura RootWindow). But this event interferes with the overscroll gesture. So, ignore such synthetic mouse-move events if an overscroll gesture is in progress. BUG=160668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168762

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 2	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11411059/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/11411059/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1574 content/browser/renderer_host/render_widget_host_view_aura.cc:1574: // on the floor. Document why you do ...

8 years, 1 month ago (2012-11-19 16:25:01 UTC) #2

sadrul

8 years, 1 month ago (2012-11-19 16:34:35 UTC) #3

http://codereview.chromium.org/11411059/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/11411059/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/render_widget_host_view_aura.cc:1574: // on the
floor.
On 2012/11/19 16:25:01, sky wrote:
> Document why you do this.

Done.

Expand Messages | Collapse Messages