Issue 11411038: Fix clang build: remove unused static function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411038: Fix clang build: remove unused static function (Closed)

Created:
8 years, 1 month ago by adamk

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev, rossberg

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix clang build: remove unused static function The last call to GetOwnPropertyImplementation() was removed in r12990. Committed: https://code.google.com/p/v8/source/detail?r=12997

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adamk

Is there a clang built bot for v8? I'm working on a Mac and seeing ...

8 years, 1 month ago (2012-11-16 19:47:35 UTC) #1

Michael Starzinger

8 years, 1 month ago (2012-11-19 09:44:32 UTC) #2

LGTM. I'll land that for you.

Actually we have coverage with Clang on our buildbots, the Webkit Mac
integration builder uses Clang for example. But it doesn't trip on this problem,
so it must be a different version of Clang I guess.

http://build.chromium.org/p/client.v8/builders/Webkit%20Mac

Expand Messages | Collapse Messages