Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 11411033: Reduced TLS accesses even further. (Closed)

Created:
8 years, 1 month ago by Sven Panne
Modified:
8 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reduced TLS accesses even further. Thread the Isolate through FindCodeInCache, FindCodeInSpecialCache and SetProperty. Reduced the number of TLS accesses while running the Octane benchmark down to 19% compared to the beginning of the cleanups. Committed: https://code.google.com/p/v8/source/detail?r=13030

Patch Set 1 #

Patch Set 2 : Reverted accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -27 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.h View 4 chunks +6 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/handles.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 6 chunks +16 lines, -6 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 1 month ago (2012-11-21 10:37:07 UTC) #1
Michael Starzinger
8 years, 1 month ago (2012-11-21 20:44:23 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698