Issue 11411003: Add per-file permissions for everybody to review changes to chrome_tests.gypi and chrome_tests_unit…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411003: Add per-file permissions for everybody to review changes to chrome_tests.gypi and chrome_tests_unit… (Closed)

Created:
8 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
8 years, 1 month ago

Reviewers:
darin (slow to review), Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add per-file permissions for everybody to review changes to chrome_tests.gypi and chrome_tests_unit.gypi Rationale: it should be easy to add new test. And if somebody screws up those files, it won't at least affect the shipping binary BUG=none R=thakis@chromium.org,darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168011

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/OWNERS	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 1 month ago (2012-11-15 18:06:25 UTC) #3

lgtm

https://codereview.chromium.org/11411003/diff/1/chrome/OWNERS
File chrome/OWNERS (right):

https://codereview.chromium.org/11411003/diff/1/chrome/OWNERS#newcode17
chrome/OWNERS:17: # per-file rules:
Can you add a comment like "These are the common case of adding or renaming
files. If you're doing structural changes, please get a review."?

Expand Messages | Collapse Messages