Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1141073002: Minor comment and style updates for on-demand update check code. (Closed)

Created:
5 years, 7 months ago by grt (UTC plus 2)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor comment and style updates for on-demand update check code. BUG=none R=ganesh@chromium.org,pkasting@chromium.org Committed: https://crrev.com/b69e31e42b63872ffa205df216e60e6eb4b75c25 Cr-Commit-Position: refs/heads/master@{#329941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/google/google_update_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_basic.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
grt (UTC plus 2)
5 years, 7 months ago (2015-05-14 13:54:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141073002/1
5 years, 7 months ago (2015-05-14 16:59:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 17:52:20 UTC) #5
S. Ganesh
lgtm
5 years, 7 months ago (2015-05-14 18:02:39 UTC) #6
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-14 21:14:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141073002/1
5 years, 7 months ago (2015-05-14 21:46:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 21:55:45 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 21:56:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b69e31e42b63872ffa205df216e60e6eb4b75c25
Cr-Commit-Position: refs/heads/master@{#329941}

Powered by Google App Engine
This is Rietveld 408576698