Use StringBuilder::appendLiteral() when possible in MarkupAccumulator

Source/core/editing/MarkupAccumulator.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 271 matching lines @@
     StringImpl* foundNS = namespaces.get(pre);
     if (foundNS != namespaceURI.impl()) {
         namespaces.set(pre, namespaceURI.impl());
         result.append(' ');
         result.append(xmlnsAtom.string());
         if (!prefix.isEmpty()) {
             result.append(':');
             result.append(prefix);
         }
 
-        result.append('=');
-        result.append('"');
+        result.appendLiteral("=\"");
         appendAttributeValue(result, namespaceURI, false);
         result.append('"');
     }
 }
 
 EntityMask MarkupAccumulator::entityMaskForText(Text* text) const
 {
     if (!text->document().isHTMLDocument())
         return EntityMaskInPCDATA;
 
@@ skipping 47 matching lines @@
     if (n->name().isEmpty())
         return;
 
     result.appendLiteral("<!DOCTYPE ");
     result.append(n->name());
     if (!n->publicId().isEmpty()) {
         result.appendLiteral(" PUBLIC \"");
         result.append(n->publicId());
         result.append('"');
         if (!n->systemId().isEmpty()) {
-            result.append(' ');
-            result.append('"');
+            result.appendLiteral(" \"");
             result.append(n->systemId());
             result.append('"');
         }
     } else if (!n->systemId().isEmpty()) {
         result.appendLiteral(" SYSTEM \"");
         result.append(n->systemId());
         result.append('"');
     }
     if (!n->internalSubset().isEmpty()) {
-        result.append(' ');
-        result.append('[');
+        result.appendLiteral(" [");
         result.append(n->internalSubset());
         result.append(']');
     }
     result.append('>');
 }
 
 void MarkupAccumulator::appendProcessingInstruction(StringBuilder& result, const String& target, const String& data)
 {
     // FIXME: PI data is not escaped, but XMLSerializer (and possibly other callers) this should raise an exception if it includes "?>".
-    result.append('<');
-    result.append('?');
+    result.appendLiteral("<?");
     result.append(target);
     result.append(' ');
     result.append(data);
-    result.append('?');
-    result.append('>');
+    result.appendLiteral("?>");
 }
 
 void MarkupAccumulator::appendElement(StringBuilder& result, Element* element, Namespaces* namespaces)
 {
     appendOpenTag(result, element, namespaces);
 
     if (element->hasAttributes()) {
         unsigned length = element->attributeCount();
         for (unsigned int i = 0; i < length; i++)
             appendAttribute(result, element, *element->attributeItem(i), namespaces);
@@ skipping 136 matching lines @@
     // or createContextualFragment.  It does not necessarily align with
     // which elements should be serialized w/o end tags.
     return toHTMLElement(node)->ieForbidsInsertHTML();
 }
 
 void MarkupAccumulator::appendEndMarkup(StringBuilder& result, const Node* node)
 {
     if (!node->isElementNode() || shouldSelfClose(node) || (!node->hasChildNodes() && elementCannotHaveEndTag(node)))
         return;
 
-    result.append('<');
-    result.append('/');
+    result.appendLiteral("</");
     result.append(toElement(node)->nodeNamePreservingCase());
     result.append('>');
 }
 
 }