Fixes #179 -- compile error if editing files during server mode

lib/src/report.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Summarizes the information produced by the checker.
 library dev_compiler.src.report;
 
 import 'dart:math' show max;
 
+import 'package:analyzer/src/generated/ast.dart' show AstNode, CompilationUnit;
+import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
 import 'package:analyzer/src/generated/source.dart' show Source;
 import 'package:logging/logging.dart';
 import 'package:path/path.dart' as path;
 import 'package:source_span/source_span.dart';
 
 import 'info.dart';
 import 'utils.dart';
 import 'summary.dart';
 
 /// A message (error or warning) produced by the dev_compiler and it's location
 /// information.
 ///
 /// Currently the location information includes only the offsets within a file
 /// where the error occurs. This is used in the context of a [CheckerReporter],
 /// where the current file is being tracked.
-abstract class Message {
+class Message {
   // Message description.
   final String message;
 
   /// Log level. This is a placeholder for severity.
   final Level level;
 
   /// Offset where the error message begins in the tracked source file.
   final int begin;
 
   /// Offset where the error message ends in the tracked source file.
   final int end;
 
   const Message(this.message, this.level, this.begin, this.end);
 }
 
-/// Like [Message], but with a precomputed source span.
-abstract class MessageWithSpan implements Message {
-  final String message;
-
-  final Level level;
-
-  final SourceSpan span;
-
-  int get begin => span.start.offset;
-  int get end => span.end.offset;
-
-  const MessageWithSpan(this.message, this.level, this.span);
-}
-
 // Interface used to report error messages from the checker.
 abstract class CheckerReporter {
+  final AnalysisContext _context;
+  CompilationUnit _unit;
+  Source _unitSource;
+
+  CheckerReporter(this._context);
+
   /// Called when starting to process a library.
   void enterLibrary(Uri uri);
   void leaveLibrary();
 
   /// Called when starting to process an HTML source file.
   void enterHtml(Uri uri);
   void leaveHtml();
 
   /// Called when starting to process a source. All subsequent log entries must
   /// belong to this source until the next call to enterSource.
-  void enterSource(Source source);
-  void leaveSource();
+  void enterCompilationUnit(CompilationUnit unit, [Source source]) {
+    _unit = unit;
+    _unitSource = source;
+  }
+  void leaveCompilationUnit() {
+    _unit = null;
+    _unitSource = null;
+  }
+
   void log(Message message);
 
   // Called in server-mode.
   void clearLibrary(Uri uri);
   void clearHtml(Uri uri);
   void clearAll();
+
+  SourceSpanWithContext _createSpan(int start, int end) =>
+      createSpan(_context, _unit, start, end, _unitSource);
 }
 
 final _checkerLogger = new Logger('dev_compiler.checker');
 
 /// Simple reporter that logs checker messages as they are seen.
-class LogReporter implements CheckerReporter {
+class LogReporter extends CheckerReporter {
   final bool useColors;
-  SourceFile _file;
   Source _current;
 
-  LogReporter([this.useColors = false]);
+  LogReporter(AnalysisContext context, {this.useColors: false})
+      : super(context);
 
   void enterLibrary(Uri uri) {}
   void leaveLibrary() {}
 
   void enterHtml(Uri uri) {}
   void leaveHtml() {}
 
-  void enterSource(Source source) {
-    _file = new SourceFile(source.contents.data, url: source.uri);
-    _current = source;
-  }
-
-  void leaveSource() {
-    _file = null;
-    _current = null;
-  }
-
   void log(Message message) {
     if (message is StaticInfo) {
-      assert((message.node as dynamic).root.element.source == _current);
+      assert(message.node.root == _unit);
     }
     // TODO(sigmund): convert to use span information from AST (issue #73)
-    final span = message is MessageWithSpan
-        ? message.span
-        : _file.span(message.begin, message.end);
+    final span = _createSpan(message.begin, message.end);
     final level = message.level;
     final color = useColors ? colorOf(level.name) : null;
     final text = '[${message.runtimeType}] ${message.message}';
     _checkerLogger.log(level, span.message(text, color: color));
   }
 
   void clearLibrary(Uri uri) {}
   void clearHtml(Uri uri) {}
   void clearAll() {}
 }
 
 /// A reporter that gathers all the information in a [GlobalSummary].
-class SummaryReporter implements CheckerReporter {
+class SummaryReporter extends CheckerReporter {
   GlobalSummary result = new GlobalSummary();
   IndividualSummary _current;
-  SourceFile _file;
+
+  SummaryReporter(AnalysisContext context) : super(context);
 
   void enterLibrary(Uri uri) {
     var container;
     if (uri.scheme == 'package') {
       var pname = path.split(uri.path)[0];
       result.packages.putIfAbsent(pname, () => new PackageSummary(pname));
       container = result.packages[pname].libraries;
     } else if (uri.scheme == 'dart') {
       container = result.system;
     } else {
       container = result.loose;
     }
     _current = container.putIfAbsent('$uri', () => new LibrarySummary('$uri'));
   }
 
   void leaveLibrary() {
     _current = null;
   }
 
   void enterHtml(Uri uri) {
     _current = result.loose.putIfAbsent('$uri', () => new HtmlSummary('$uri'));
   }
 
   void leaveHtml() {
     _current = null;
   }
 
-  void enterSource(Source source) {
-    _file = new SourceFile(source.contents.data, url: source.uri);
+  @override
+  void enterCompilationUnit(CompilationUnit unit, [Source source]) {
+    super.enterCompilationUnit(unit, source);
     if (_current is LibrarySummary) {
-      (_current as LibrarySummary).lines += _file.lines;
+      int lines = _unit.lineInfo.getLocation(_unit.endToken.end).lineNumber;
+      (_current as LibrarySummary).lines += lines;
     }
   }
 
-  void leaveSource() {
-    _file = null;
-  }
-
   void log(Message message) {
-    assert(message is MessageWithSpan || _file != null);
-    // TODO(sigmund): convert to use span information from AST (issue #73)
-    final span = message is MessageWithSpan
-        ? message.span
-        : _file.span(message.begin, message.end);
+    final span = _createSpan(message.begin, message.end);
     _current.messages.add(new MessageSummary('${message.runtimeType}',
         message.level.name.toLowerCase(), span, message.message));
   }
 
   void clearLibrary(Uri uri) {
     enterLibrary(uri);
     _current.messages.clear();
     (_current as LibrarySummary).lines = 0;
     leaveLibrary();
   }
@@ skipping 200 matching lines @@
 
   visitMessage(MessageSummary message) {
     var kind = message.kind;
     errorCount.putIfAbsent(currentPackage, () => <String, int>{});
     errorCount[currentPackage].putIfAbsent(kind, () => 0);
     errorCount[currentPackage][kind]++;
     totals.putIfAbsent(kind, () => 0);
     totals[kind]++;
   }
 }