ui: Enable debug borders for the UI compositor through layer tree settings.

ui: Enable debug borders for the UI compositor through layer tree settings.

We have disconnected the debug borders in the compositor from GraphicsLayer, and
have internal mechanisms in the compositor for deciding layer borders. This
feature is enabled via LayerTreeSettings.

The ui compositor was setting border colors and widths directly. Instead, it
should enable the LayerTreeSettings flag, and any layer-specific colors should
be defined in the compositor, making them consistent for UI or renderer.

BUG=159769
R=piman
Depends on: https://codereview.chromium.org/11365239

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167864

[danakj, 2012-11-14 21:14:14]

piman's out for the week. can you review please backer?

[jonathan.backer, 2012-11-14 21:39:11]

https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc
File ui/compositor/layer.cc (left):

https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc#oldcod...
ui/compositor/layer.cc:796: web_layer_->setDebugBorderColor(color);
Is the purpose of this code to give the UI layer borders a different color than
the renderer layer borders? I feel like we may be losing some functionality
here.

[jonathan.backer, 2012-11-14 21:45:37]

On 2012/11/14 21:39:11, jonathan.backer wrote:
> https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc
> File ui/compositor/layer.cc (left):
> 
>
https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc#oldcod...
> ui/compositor/layer.cc:796: web_layer_->setDebugBorderColor(color);
> Is the purpose of this code to give the UI layer borders a different color
than
> the renderer layer borders? I feel like we may be losing some functionality
> here.

I see you've already nuked these in CC :D

We've got two separate flags for the layer borders, so haven't different colors
doesn't seem critical.

lgtm.

[danakj, 2012-11-14 22:26:38]

Thanks Jon

https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc
File ui/compositor/layer.cc (left):

https://codereview.chromium.org/11410098/diff/1/ui/compositor/layer.cc#oldcod...
ui/compositor/layer.cc:796: web_layer_->setDebugBorderColor(color);
On 2012/11/14 21:39:12, jonathan.backer wrote:
> Is the purpose of this code to give the UI layer borders a different color
than
> the renderer layer borders? I feel like we may be losing some functionality
> here.

As per offline, this was the way to get layer borders previously. It did set
more colors than we got in the compositor. Now we have added a number of new
colors there. We can also plumb through any other debug tools that UI would like
to use such as opaque rects, non-opaque rects, paint rects, etc.

The tiled vs non-tiled borders will still be different (green vs orange), and
now also clipping layers and other container layers will get colors.

We can add any other colors based on state to cc/layer_impl.cc as desired. But
the border colors get overloaded pretty quickly. (This will also now provide
colors for surface borders, and show draw culling.) So adding more visualization
via the hud rects with additional flags seems better.

Once we don't use WebLayerTreeView anymore, they'll all be exposed for free.

[commit-bot: I haz the power, 2012-11-15 01:49:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11410098/1

[commit-bot: I haz the power, 2012-11-15 05:28:51]

Change committed as 167864