Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tests/corelib/list_iterators_test.dart

Issue 11410086: Use iterator, moveNext(), current. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/list_iterators_test.dart
diff --git a/tests/corelib/list_iterators_test.dart b/tests/corelib/list_iterators_test.dart
index 6f29061fb0fb28e9535daf5284e6e2c4c975cf45..61f66cbe8663c521eac674b8339da3126253edf4 100644
--- a/tests/corelib/list_iterators_test.dart
+++ b/tests/corelib/list_iterators_test.dart
@@ -4,20 +4,14 @@
class ListIteratorsTest {
static void checkListIterator(List a) {
- Iterator it = a.iterator();
- Expect.equals(false, it.hasNext == a.isEmpty);
+ Iterator it = a.iterator;
for (int i = 0; i < a.length; i++) {
- Expect.equals(true, it.hasNext);
- var elem = it.next();
+ Expect.isTrue(it.moveNext());
+ var elem = it.current;
+ Expect.equals(a[i], elem);
}
- Expect.equals(false, it.hasNext);
- bool exceptionCaught = false;
- try {
- var eleme = it.next();
- } on StateError catch (e) {
- exceptionCaught = true;
- }
- Expect.equals(true, exceptionCaught);
+ Expect.isFalse(it.moveNext());
+ Expect.throws(() { it.current; }, (e) => e is StateError);
}
static testMain() {
@@ -27,16 +21,19 @@ class ListIteratorsTest {
checkListIterator(new List(10));
checkListIterator(new List());
List g = new List();
- g.addAll([1, 2]);
+ g.addAll([1, 2, 3]);
checkListIterator(g);
- Iterator it = g.iterator();
- Expect.equals(true, it.hasNext);
+ Iterator it = g.iterator;
+ Expect.isTrue(it.moveNext());
g.removeLast();
- Expect.equals(true, it.hasNext);
+ Expect.equals(1, it.current);
+ Expect.isTrue(it.moveNext());
g.removeLast();
- Expect.equals(false, it.hasNext);
+ Expect.throws(() => it.current);
+ Expect.isFalse(it.moveNext());
+ g.clear();
g.addAll([10, 20]);
int sum = 0;
for (var elem in g) {

Powered by Google App Engine
This is Rietveld 408576698