sdk/lib/collection/collections.dart - Issue 11410086: Use iterator, moveNext(), current.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/collection/collections.dart

Issue 11410086: Use iterator, moveNext(), current. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/collection/collections.dart

diff --git a/sdk/lib/collection/collections.dart b/sdk/lib/collection/collections.dart

index 29fe0deb40102ad863fbc471c1165b4e61724e51..df0f412436462dd1ba6e7591a48d160b8042e726 100644

--- a/sdk/lib/collection/collections.dart

+++ b/sdk/lib/collection/collections.dart

@@ -59,7 +59,7 @@ class Collections {

}

static bool isEmpty(Iterable iterable) {

- return !iterable.iterator().hasNext;

+ return !iterable.iterator.moveNext();

}

// TODO(jjb): visiting list should be an identityHashSet when it exists