Use iterator, moveNext(), current.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 230 matching lines @@
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)),
                      ECX);
   // Caller is responsible of preserving the value if necessary.
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
-static intptr_t GetOffsetForField(const char* class_name_p,
-                                  const char* field_name_p) {
-  const String& class_name = String::Handle(Symbols::New(class_name_p));
-  const String& field_name = String::Handle(Symbols::New(field_name_p));
-  const Library& core_lib = Library::Handle(Library::CoreLibrary());
-  const Class& cls =
-      Class::Handle(core_lib.LookupClassAllowPrivate(class_name));
-  ASSERT(!cls.IsNull());
-  const Field& field = Field::ZoneHandle(cls.LookupInstanceField(field_name));
-  ASSERT(!field.IsNull());
-  return field.Offset();
-}
-
-
 // Allocate a GrowableObjectArray using the backing array specified.
 // On stack: type argument (+2), data (+1), return-address (+0).
 bool Intrinsifier::GArray_Allocate(Assembler* assembler) {
   // This snippet of inlined code uses the following registers:
   // EAX, EBX
   // and the newly allocated object is returned in EAX.
   const intptr_t kTypeArgumentsOffset = 2 * kWordSize;
   const intptr_t kArrayOffset = 1 * kWordSize;
   Label fall_through;
 
@@ skipping 1304 matching lines @@
   __ cmpl(EAX, Address(ESP, + 2 * kWordSize));
   __ j(EQUAL, &is_true, Assembler::kNearJump);
   __ LoadObject(EAX, bool_false);
   __ ret();
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
-
-static const char* kFixedSizeArrayIteratorClassName = "_FixedSizeArrayIterator";
-
-
-// Class 'FixedSizeArrayIterator':
-//   T next() {
-//     return _array[_pos++];
-//   }
-// Intrinsify: return _array[_pos++];
-// TODO(srdjan): Throw a 'StateError' exception if the iterator
-// has no more elements.
-bool Intrinsifier::FixedSizeArrayIterator_next(Assembler* assembler) {
-  Label fall_through;
-  intptr_t array_offset =
-      GetOffsetForField(kFixedSizeArrayIteratorClassName, "_array");
-  intptr_t pos_offset =
-      GetOffsetForField(kFixedSizeArrayIteratorClassName, "_pos");
-  ASSERT(array_offset >= 0 && pos_offset >= 0);
-  // Receiver is not NULL.
-  __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Receiver.
-  __ movl(EBX, FieldAddress(EAX, pos_offset));  // Field _pos.
-  // '_pos' cannot be greater than array length and therefore is always Smi.
-#if defined(DEBUG)
-  Label pos_ok;
-  __ testl(EBX, Immediate(kSmiTagMask));
-  __ j(ZERO, &pos_ok, Assembler::kNearJump);
-  __ Stop("pos must be Smi");
-  __ Bind(&pos_ok);
-#endif
-  // Check that we are not trying to call 'next' when 'hasNext' is false.
-  __ movl(EAX, FieldAddress(EAX, array_offset));  // Field _array.
-  __ cmpl(EBX, FieldAddress(EAX, Array::length_offset()));  // Range check.
-  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
-
-  // EBX is Smi, i.e, times 2.
-  ASSERT(kSmiTagShift == 1);
-  __ movl(EDI, FieldAddress(EAX, EBX, TIMES_2, sizeof(RawArray)));  // Result.
-  const Immediate value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
-  __ addl(EBX, value);  // _pos++.
-  __ j(OVERFLOW, &fall_through, Assembler::kNearJump);
-  __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Receiver.
-  __ StoreIntoObjectNoBarrier(EAX,
-                              FieldAddress(EAX, pos_offset),
-                              EBX);  // Store _pos.
-  __ movl(EAX, EDI);
-  __ ret();
-  __ Bind(&fall_through);
-  return false;
-}
-
-
-// Class 'FixedSizeArrayIterator':
-//   bool get hasNext {
-//     return _length > _pos;
-//   }
-bool Intrinsifier::FixedSizeArrayIterator_getHasNext(Assembler* assembler) {
-  Label fall_through, is_true;
-  const Bool& bool_true = Bool::ZoneHandle(Bool::True());
-  const Bool& bool_false = Bool::ZoneHandle(Bool::False());
-  intptr_t length_offset =
-      GetOffsetForField(kFixedSizeArrayIteratorClassName, "_length");
-  intptr_t pos_offset =
-      GetOffsetForField(kFixedSizeArrayIteratorClassName, "_pos");
-  __ movl(EAX, Address(ESP, + 1 * kWordSize));     // Receiver.
-  __ movl(EBX, FieldAddress(EAX, length_offset));  // Field _length.
-  __ movl(EAX, FieldAddress(EAX, pos_offset));    // Field _pos.
-  __ movl(EDI, EAX);
-  __ orl(EDI, EBX);
-  __ testl(EDI, Immediate(kSmiTagMask));
-  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi _length.
-  __ cmpl(EBX, EAX);     // _length > _pos.
-  __ j(GREATER, &is_true, Assembler::kNearJump);
-  __ LoadObject(EAX, bool_false);
-  __ ret();
-  __ Bind(&is_true);
-  __ LoadObject(EAX, bool_true);
-  __ ret();
-  __ Bind(&fall_through);
-  return false;
-}
-
-
 bool Intrinsifier::String_getHashCode(Assembler* assembler) {
   Label fall_through;
   __ movl(EAX, Address(ESP, + 1 * kWordSize));  // String object.
   __ movl(EAX, FieldAddress(EAX, String::hash_offset()));
   __ cmpl(EAX, Immediate(0));
   __ j(EQUAL, &fall_through, Assembler::kNearJump);
   __ ret();
   __ Bind(&fall_through);
   // Hash not yet computed.
   return false;
@@ skipping 44 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32