Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 11410062: Merge 133429 - Shadow DOM should be able to be disabled per context. (Closed)

Created:
8 years, 1 month ago by Hajime Morrita
Modified:
8 years, 1 month ago
Reviewers:
gmorrita
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133429 - Shadow DOM should be able to be disabled per context. https://bugs.webkit.org/show_bug.cgi?id=101173 Reviewed by Dimitri Glazkov. Source/WebCore: This change pulls back relevant bits from r131549. Note that if the the port enables runtime Shadow DOM flag, this can cause slow down on some Chromium page cycler test cases (which r131549 attempted to fix). This change is temporal and the flags should be switched back from ContextFeatures to RuntimeEnabledFeatures once it gains sufficent stability. * dom/ContextFeatures.cpp: (WebCore::ContextFeatures::shadowDOMEnabled): (WebCore): * dom/ContextFeatures.h: * dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::findParent): * dom/TreeScope.cpp: (WebCore::TreeScope::getSelection): * html/HTMLTagNames.in: * html/shadow/HTMLContentElement.cpp: (WebCore::HTMLContentElement::contentTagName): * page/DOMWindow.idl: Source/WebKit/chromium: * src/ContextFeaturesClientImpl.cpp: (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): TBR=morrita@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M Source/WebCore/dom/ContextFeatures.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/dom/ContextFeatures.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Position.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/dom/TreeScope.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLTagNames.in View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/shadow/HTMLContentElement.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hajime Morrita
8 years, 1 month ago (2012-11-13 06:34:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698