tools/testing/dart/status_file_parser.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move out RegExp constructors to top-level elements. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/status_file_parser.dart

diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart

index c3b70d8cca6496b726e221fd52fbf9454d808bb8..5d3cee637c24426203a41bbd4f8e8266e11439dc 100644

--- a/tools/testing/dart/status_file_parser.dart

+++ b/tools/testing/dart/status_file_parser.dart

@@ -23,9 +23,9 @@ const OK = "ok";

const SLOW = "slow";

-const RegExp StripComment = const RegExp("^[^#]*");

-const RegExp HeaderPattern = const RegExp(r"^\[([^\]]+)\]");

-const RegExp RulePattern = const RegExp(r"\s*([^: ]*)\s*:(.*)");

+final RegExp StripComment = new RegExp("^[^#]*");

+final RegExp HeaderPattern = new RegExp(r"^\[([^\]]+)\]");

+final RegExp RulePattern = new RegExp(r"\s*([^: ]*)\s*:(.*)");

// TODO(whesse): Implement configuration_info library that contains data

// structures for test configuration, including Section.