tests/compiler/dart2js/class_codegen2_test.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/class_codegen2_test.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move out RegExp constructors to top-level elements. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/class_codegen2_test.dart

diff --git a/tests/compiler/dart2js/class_codegen2_test.dart b/tests/compiler/dart2js/class_codegen2_test.dart

index 91b6b97f731ba25179817afd23dea4d8bbcda694..730a59a3983e2e173400a9c9147943b9bf0f21ae 100644

--- a/tests/compiler/dart2js/class_codegen2_test.dart

+++ b/tests/compiler/dart2js/class_codegen2_test.dart

@@ -85,7 +85,7 @@ main() {

main() {

// At some point Dart2js generated bad object literals with dangling commas:

// { a: true, }. Make sure this doesn't happen again.

- RegExp danglingComma = const RegExp(r',[ \n]*}');

+ RegExp danglingComma = new RegExp(r',[ \n]*}');

String generated = compileAll(TEST_ONE);

Expect.isFalse(danglingComma.hasMatch(generated));