sdk/lib/core/date.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/date.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move out RegExp constructors to top-level elements. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/core/date.dart

diff --git a/sdk/lib/core/date.dart b/sdk/lib/core/date.dart

index 7ab46cf07baed8de1341cfc2f0b0a5ae6b92cd8c..bb62735da5589c872c0fb529b9a798013e946ac1 100644

--- a/sdk/lib/core/date.dart

+++ b/sdk/lib/core/date.dart

@@ -257,7 +257,7 @@ class _DateImpl implements Date {

// - "20120227"

// - "2012-02-27T14Z"

// - "-123450101 00:00:00 Z" // In the year -12345.

- final RegExp re = const RegExp(

+ final RegExp re = new RegExp(

r'^([+-]?\d?\d\d\d\d)-?(\d\d)-?(\d\d)' // The day part.

r'(?:[ T](\d\d)(?::?(\d\d)(?::?(\d\d)(.\d{1,6})?)?)? ?([zZ])?)?$');

Match match = re.firstMatch(formattedString);