pkg/webdriver/lib/webdriver.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/webdriver/lib/webdriver.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move out RegExp constructors to top-level elements. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/webdriver/lib/webdriver.dart

diff --git a/pkg/webdriver/lib/webdriver.dart b/pkg/webdriver/lib/webdriver.dart

index efb6a415c3671a54d40694c2c1277768bf8c8c20..8291db842d1a13b821d11e9a24ad0397f607e4c9 100644

--- a/pkg/webdriver/lib/webdriver.dart

+++ b/pkg/webdriver/lib/webdriver.dart

@@ -201,7 +201,7 @@ class WebDriverBase {

WebDriverBase.fromUrl([this._url = 'http://localhost:4444/wd/hub']) {

// Break out the URL components.

- var re = const RegExp('[^:/]+://([^/]+)(/.*)');

+ var re = new RegExp('[^:/]+://([^/]+)(/.*)');

var matches = re.firstMatch(_url);

_host = matches[1];

_path = matches[2];