pkg/unittest/lib/html_layout_config.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/html_layout_config.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move out RegExp constructors to top-level elements. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/unittest/lib/html_layout_config.dart

diff --git a/pkg/unittest/lib/html_layout_config.dart b/pkg/unittest/lib/html_layout_config.dart

index 1e56248fdb1e512386c3cfdb166532432b5dc292..a452e7934ea697b1bdba217481f8a0e78a898cc0 100644

--- a/pkg/unittest/lib/html_layout_config.dart

+++ b/pkg/unittest/lib/html_layout_config.dart

@@ -40,7 +40,7 @@ class _Message {

_Message.fromString(String msg) {

// The format of a message is '<type> <elapsedTime> <body>'.

// If we don't get a type we default to a 'log' type.

- var messageParser = const RegExp('\([a-z]*\) \([0-9]*\) \(.*\)');

+ var messageParser = new RegExp('\([a-z]*\) \([0-9]*\) \(.*\)');

Match match = messageParser.firstMatch(msg);

if (match == null) {

messageType = 'log';