sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/native_handler.dart ('K') | « sdk/lib/_internal/compiler/implementation/native_handler.dart ('k') | sdk/lib/_internal/dartdoc/lib/dartdoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart b/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

index b416c3fecbb98e23be5d2912a7a242f4bf5e2ac1..62c13432db4a1d12a0e888e85467b3f7ea716245 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

@@ -550,7 +550,7 @@ class VariableNamer {

void freeName(HInstruction instruction) {

String ownName = names.ownName[instruction];

if (ownName != null) {

- RegExp regexp = const RegExp('t[0-9]+');

+ RegExp regexp = new RegExp('t[0-9]+');

ahe 2012/11/12 13:35:03 Top-level final field?

Anders Johnsen 2012/11/12 13:45:38 Done, +static.

// We check if we have already looked for temporary names

// because if we haven't, chances are the temporary we allocate

// in this block can match a phi with the same name in the