Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: utils/apidoc/html_diff.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review update Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/apidoc/apidoc.dart ('k') | utils/apidoc/mdn/extract.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A script to assist in documenting the difference between the dart:html API 6 * A script to assist in documenting the difference between the dart:html API
7 * and the old DOM API. 7 * and the old DOM API.
8 */ 8 */
9 library html_diff; 9 library html_diff;
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 /** 221 /**
222 * Extracts a [Map] from tag names to values from [comment], which is parsed 222 * Extracts a [Map] from tag names to values from [comment], which is parsed
223 * from a Dart source file via dartdoc. Tags are of the form `@NAME VALUE`, 223 * from a Dart source file via dartdoc. Tags are of the form `@NAME VALUE`,
224 * where `NAME` is alphabetic and `VALUE` can contain any character other than 224 * where `NAME` is alphabetic and `VALUE` can contain any character other than
225 * `;`. Multiple tags can be separated by semicolons. 225 * `;`. Multiple tags can be separated by semicolons.
226 * 226 *
227 * At time of writing, the only tag that's used is `@domName`. 227 * At time of writing, the only tag that's used is `@domName`.
228 */ 228 */
229 Map<String, String> _getTags(String comment) { 229 Map<String, String> _getTags(String comment) {
230 if (comment == null) return const <String, String>{}; 230 if (comment == null) return const <String, String>{};
231 final re = const RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)"); 231 final re = new RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");
232 final tags = <String, String>{}; 232 final tags = <String, String>{};
233 for (var m in re.allMatches(comment.trim())) { 233 for (var m in re.allMatches(comment.trim())) {
234 tags[m[1]] = m[2]; 234 tags[m[1]] = m[2];
235 } 235 }
236 return tags; 236 return tags;
237 } 237 }
238 } 238 }
OLDNEW
« no previous file with comments | « utils/apidoc/apidoc.dart ('k') | utils/apidoc/mdn/extract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698