Make RegExp's constructor non-const.

sdk/lib/_internal/compiler/implementation/js/printer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js;
 
 class Printer implements NodeVisitor {
   final bool shouldCompressOutput;
   leg.Compiler compiler;
   leg.CodeBuffer outBuffer;
@@ skipping 28 matching lines @@
 
   String lastAddedString = null;
   int get lastCharCode {
     if (lastAddedString == null) return 0;
     assert(lastAddedString.length != "");
     return lastAddedString.charCodeAt(lastAddedString.length - 1);
   }
 
   void out(String str) {
     if (str != "") {
-      const identifierRegexp = const RegExp(r'^[a-zA-Z_0-9$]');
+      final identifierRegexp = new RegExp(r'^[a-zA-Z_0-9$]');

[ahe, 2012/11/12 13:35:03]

I think this should be a static final field.

[Anders Johnsen, 2012/11/12 13:45:38]

Done.

       if (pendingSemicolon && (!shouldCompressOutput || str != "}")) {
         outBuffer.add(";");
       }
       if (pendingSpace &&
           (!shouldCompressOutput || identifierRegexp.hasMatch(str))) {
         outBuffer.add(" ");
       }
       pendingSpace = false;
       pendingSemicolon = false;
       outBuffer.add(str);
@@ skipping 1000 matching lines @@
         nameSpaceSize *= LETTERS;
       }
       var codes = <int>[];
       for (var i = 0; i < alphaChars; i++) {
         nameSpaceSize ~/= LETTERS;
         codes.add(nthLetter((n ~/ nameSpaceSize) % LETTERS));
       }
       codes.add(charCodes.$0 + digit);
       newName = new String.fromCharCodes(codes);
     }
-    assert(const RegExp(r'[a-zA-Z][a-zA-Z0-9]*').hasMatch(newName));
+    assert(new RegExp(r'[a-zA-Z][a-zA-Z0-9]*').hasMatch(newName));
     maps.last[oldName] = newName;
     return newName;
   }
 }