runtime/vm/dart_api_impl.cc - Issue 11410032: Add support for non ASCII strings when communicating with native ports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11410032: Add support for non ASCII strings when communicating with native ports (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase + update test expectations Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index f3ea2810f78b05df283626bf2ba5c4873fdde075..c69f875919ec8ad09f5cc869a90c2b097dc8965c 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1019,10 +1019,13 @@ DART_EXPORT bool Dart_PostIntArray(Dart_Port port_id,

}

-DART_EXPORT bool Dart_PostCObject(Dart_Port port_id, Dart_CObject* message) {

+DART_EXPORT bool Dart_PostCObject(Dart_Port port_id,

+ Dart_CObject* message) {

Ivan Posva 2012/11/14 19:07:15 No need to wrap the line.

Søren Gjesse 2012/11/15 08:16:53 https://codereview.chromium.org//11308031.

uint8_t* buffer = NULL;

ApiMessageWriter writer(&buffer, allocator);

- writer.WriteCMessage(message);

+ bool success = writer.WriteCMessage(message);

+ if (!success) return success;

// Post the message at the given port.

return PortMap::PostMessage(new Message(

« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart_api_message.h » ('j') | tests/standalone/standalone.status » ('J')