Add support for non ASCII strings when communicating with native ports

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1001 matching lines @@
   ApiMessageWriter writer(&buffer, &allocator);
   writer.WriteMessage(len, data);
 
   // Post the message at the given port.
   return PortMap::PostMessage(new Message(
       port_id, Message::kIllegalPort, buffer, writer.BytesWritten(),
       Message::kNormalPriority));
 }
 
 
-DART_EXPORT bool Dart_PostCObject(Dart_Port port_id, Dart_CObject* message) {
+DART_EXPORT bool Dart_PostCObject(Dart_Port port_id,
+                                  Dart_CObject* message) {

[Ivan Posva, 2012/11/14 19:07:15]

No need to wrap the line.

[Søren Gjesse, 2012/11/15 08:16:53]

https://codereview.chromium.org//11308031.

   uint8_t* buffer = NULL;
   ApiMessageWriter writer(&buffer, allocator);
-  writer.WriteCMessage(message);
+  bool success = writer.WriteCMessage(message);
+
+  if (!success) return success;
 
   // Post the message at the given port.
   return PortMap::PostMessage(new Message(
       port_id, Message::kIllegalPort, buffer, writer.BytesWritten(),
       Message::kNormalPriority));
 }
 
 
 DART_EXPORT bool Dart_Post(Dart_Port port_id, Dart_Handle handle) {
   Isolate* isolate = Isolate::Current();
@@ skipping 3427 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success(isolate);
 }
 
 }  // namespace dart