Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1141003002: Move linux sysroots from chrome/installer/linux to build/linux (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang, Nico, binji, Torne
CC:
chromium-reviews, binji+watch_chromium.org, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move linux sysroots from chrome/installer/linux to build/linux The sysroot are generally useful (for example when cross compiling) and not limited to use in the installer or official releases. Another reason to move this is that it would allow other projects to more easily share chromium's build setup without depending on chrome/. Also, rename the install script to simply install-sysroot. This way the script can keep the same name and support multiple different debian releases without needing to duplicate the script (e.g. when we switch to jessie). BUG=504446 TEST=cross build chromium for arm and ia32 Committed: https://crrev.com/8208b4d81396c11e1f8ca8f6ffe52b9fcea87d05 Cr-Commit-Position: refs/heads/master@{#336843}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1918 lines) Patch
M .gitignore View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M DEPS View 1 2 3 4 5 6 1 chunk +4 lines, -6 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +2 lines, -3 lines 0 comments Download
A + build/linux/OWNERS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A + build/linux/sysroot_scripts/install-sysroot.py View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
A + build/linux/sysroot_scripts/packagelist.trusty.arm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/packagelist.wheezy.arm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/packagelist.wheezy.i386 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/sysroot-creator.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/sysroot-creator-test.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 1 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/packagelist.trusty.arm View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm View 1 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/sysroot-creator.sh View 1 1 chunk +0 lines, -700 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/installer/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 1 chunk +0 lines, -177 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +2 lines, -3 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (12 generated)
Sam Clegg
5 years, 6 months ago (2015-06-23 18:37:12 UTC) #2
Lei Zhang
Can you copy the owners from c/i/linux/OWNERS to build/linux/OWNERS? https://codereview.chromium.org/1141003002/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/1141003002/diff/40001/DEPS#newcode532 DEPS:532: ...
5 years, 6 months ago (2015-06-23 19:05:07 UTC) #3
Sam Clegg
On 2015/06/23 19:05:07, Lei Zhang wrote: > Can you copy the owners from c/i/linux/OWNERS to ...
5 years, 6 months ago (2015-06-23 19:25:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141003002/60001
5 years, 6 months ago (2015-06-23 19:27:19 UTC) #6
Lei Zhang
lgtm, but you may need additional owners.
5 years, 6 months ago (2015-06-23 19:56:54 UTC) #7
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-23 20:05:35 UTC) #9
Sam Clegg
+binji and +thakis for /native_client_sdk/ and /build/
5 years, 6 months ago (2015-06-25 05:22:01 UTC) #11
Nico
Can you file a tracking bug for this? Then you can mark other efforts that ...
5 years, 6 months ago (2015-06-25 05:24:27 UTC) #12
Sam Clegg
On 2015/06/25 05:24:27, Nico wrote: > Can you file a tracking bug for this? Then ...
5 years, 6 months ago (2015-06-25 18:07:22 UTC) #13
binji
On 2015/06/25 at 05:22:01, sbc wrote: > +binji and +thakis for /native_client_sdk/ and /build/ native_client_sdk ...
5 years, 6 months ago (2015-06-25 18:11:09 UTC) #14
Nico
lgtm
5 years, 6 months ago (2015-06-25 21:09:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141003002/60001
5 years, 5 months ago (2015-06-29 18:30:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/39040)
5 years, 5 months ago (2015-06-29 20:44:21 UTC) #19
Sam Clegg
+torne for copyright_scanner
5 years, 5 months ago (2015-06-29 21:22:56 UTC) #21
Torne
lgtm
5 years, 5 months ago (2015-06-30 11:13:41 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141003002/100001
5 years, 5 months ago (2015-06-30 14:10:29 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/39380)
5 years, 5 months ago (2015-06-30 16:46:12 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141003002/120001
5 years, 5 months ago (2015-06-30 16:53:59 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-06-30 19:14:30 UTC) #31
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 19:16:04 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8208b4d81396c11e1f8ca8f6ffe52b9fcea87d05
Cr-Commit-Position: refs/heads/master@{#336843}

Powered by Google App Engine
This is Rietveld 408576698