Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 11410030: Merge 133030 - Web Inspector: page crash when pausing in dedicated worker (Closed)

Created:
8 years, 1 month ago by yurys
Modified:
8 years, 1 month ago
Reviewers:
yurys
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 133030 - Web Inspector: page crash when pausing in dedicated worker https://bugs.webkit.org/show_bug.cgi?id=100837 Reviewed by Pavel Feldman. Source/WebCore: Pass debugger agent to InjectedScriptHost::init in case of workers. Test: inspector-protocol/debugger-pause-dedicated-worker.html * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController): LayoutTests: Test that Debugger.pause works for dedicated workers. The test is skipped on all platforms that use JSC as worker debugging is not supported there yet. * http/tests/inspector-protocol/resources/InspectorTest.js: (WebInspector.dispatchMessageFromBackend): * inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added. * inspector-protocol/debugger-pause-dedicated-worker.html: Added. * inspector-protocol/resources/dedicated-worker.js: Added. (onmessage): (doWork): * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/qt/TestExpectations: * platform/win/TestExpectations: * platform/wincairo/TestExpectations: TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/WebCore/inspector/WorkerInspectorController.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
yurys
8 years, 1 month ago (2012-11-12 08:10:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698