ui: Add SkIRectToRect() function to convert from SkIRect type to gfx::Rect.

ui: Add SkIRectToRect() function to convert from SkIRect type to gfx::Rect.

This fixes the 3 TODOs for Dana from region.*

TEST=cc_unittests,ui_unittests
R=danakj@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167244

[tfarina, 2012-11-10 20:12:53]

Hi Dana, could you review this to me?

[danakj, 2012-11-11 18:57:02]

http://codereview.chromium.org/11410025/diff/1/cc/region.h
File cc/region.h (right):

http://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode13
cc/region.h:13: #include "ui/gfx/skia_util.h"
sort order

http://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode46
cc/region.h:46: bool Equals(const Region& other) const;
Why moved?

[tfarina, 2012-11-11 19:43:25]

http://codereview.chromium.org/11410025/diff/1/cc/region.h
File cc/region.h (right):

http://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode46
cc/region.h:46: bool Equals(const Region& other) const;
On 2012/11/11 18:57:02, danakj wrote:
> Why moved?
For two reasons:

- To be consistent with the above method declarations
- Because it was using more than 80 columns, ok, that is not a good reason
because I could have wrapped as:
bool Equals(const Region& other) const {
  return skregion_ == other.skregion_;
}

But I felt it would be nicer to have everything declared in the header and
everything defined/implemented in the source.

I can revert if you are strong about this though.

[danakj, 2012-11-11 19:45:45]

lgtm after that.

http://codereview.chromium.org/11410025/diff/1/cc/region.h
File cc/region.h (right):

http://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode46
cc/region.h:46: bool Equals(const Region& other) const;
On 2012/11/11 19:43:25, tfarina wrote:
> On 2012/11/11 18:57:02, danakj wrote:
> > Why moved?
> For two reasons:
> 
> - To be consistent with the above method declarations
> - Because it was using more than 80 columns, ok, that is not a good reason
> because I could have wrapped as:
> bool Equals(const Region& other) const {
>   return skregion_ == other.skregion_;
> }
> 
> But I felt it would be nicer to have everything declared in the header and
> everything defined/implemented in the source.
> 
> I can revert if you are strong about this though.

Ya, I'd rather keep simple methods like that in the header.

[tfarina, 2012-11-11 19:58:14]

https://codereview.chromium.org/11410025/diff/1/cc/region.h
File cc/region.h (right):

https://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode13
cc/region.h:13: #include "ui/gfx/skia_util.h"
On 2012/11/11 18:57:02, danakj wrote:
> sort order

Done.

https://codereview.chromium.org/11410025/diff/1/cc/region.h#newcode46
cc/region.h:46: bool Equals(const Region& other) const;
On 2012/11/11 19:45:45, danakj wrote:
> On 2012/11/11 19:43:25, tfarina wrote:
> > On 2012/11/11 18:57:02, danakj wrote:
> > > Why moved?
> > For two reasons:
> > 
> > - To be consistent with the above method declarations
> > - Because it was using more than 80 columns, ok, that is not a good reason
> > because I could have wrapped as:
> > bool Equals(const Region& other) const {
> >   return skregion_ == other.skregion_;
> > }
> > 
> > But I felt it would be nicer to have everything declared in the header and
> > everything defined/implemented in the source.
> > 
> > I can revert if you are strong about this though.
> 
> Ya, I'd rather keep simple methods like that in the header.

Done.

[tfarina, 2012-11-11 19:59:39]

Hi Scott, could you review the ui/gfx addition for me?

[sky, 2012-11-12 04:22:31]

LGTM