Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: base/trace_event/winheap_dump_provider_win_unittest.cc

Issue 1140943006: Walking heaps from GetProcessHeaps is flaky by design, failing on XP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/winheap_dump_provider_win_unittest.cc
diff --git a/base/trace_event/winheap_dump_provider_win_unittest.cc b/base/trace_event/winheap_dump_provider_win_unittest.cc
index 2309802fe7943fec8985b0b516b03f6ba32fa0bd..4f3dcce1b2c8284b115c604aca2c2cc0036fd551 100644
--- a/base/trace_event/winheap_dump_provider_win_unittest.cc
+++ b/base/trace_event/winheap_dump_provider_win_unittest.cc
@@ -13,7 +13,9 @@
namespace base {
namespace trace_event {
-TEST(WinHeapDumpProviderTest, OnMemoryDump) {
+// This test is flaky on XP and is not guaranteed reliable on any version of
+// Windows. https://crbug.com/487291
+TEST(WinHeapDumpProviderTest, DISABLED_OnMemoryDump) {
ProcessMemoryDump pmd(make_scoped_refptr(new MemoryDumpSessionState()));
WinHeapDumpProvider* winheap_dump_provider =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698