Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1140933002: [turbofan] Lower more number operations to integer operations. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower more number operations to integer operations. If the typer was able to prove that a NumberAdd/Sub/Mul/Div/Mod always produces a Signed32/Unsigned32 value, and the inputs are Signed32/Unsigned32, we can lower the node to the corresponding integer operation instead, no matter what the uses are. R=jarin@chromium.org Committed: https://crrev.com/225a6adc2ad8f971195394fa850e9cc7eafd6ed7 Cr-Commit-Position: refs/heads/master@{#28393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-13 12:32:07 UTC) #1
Benedikt Meurer
Hey Jaro, The simplified lowering patch. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-13 12:32:48 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-13 12:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140933002/1
5 years, 7 months ago (2015-05-13 12:35:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 12:54:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 12:54:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/225a6adc2ad8f971195394fa850e9cc7eafd6ed7
Cr-Commit-Position: refs/heads/master@{#28393}

Powered by Google App Engine
This is Rietveld 408576698