Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1140913002: Add Layer Id information to the LayerTree json string (Closed)

Created:
5 years, 7 months ago by r.kasibhatla
Modified:
5 years, 7 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Layer Id information to the LayerTree json string LayerTreeAsJson is useful during debugging of layer tree operations. Adding the layer id into the information for the layer currently being serialized. This helps the function be more usable as user knows which layer he is looking when checking the json. BUG=None R=danakj,enne Committed: https://crrev.com/fd17d0e9e5ca003cb323c30225681f5719fc64db Cr-Commit-Position: refs/heads/master@{#330306}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding only layer id to the json! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/layers/layer_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
r.kasibhatla
PTAL. A small change.
5 years, 7 months ago (2015-05-13 12:06:15 UTC) #2
danakj
https://codereview.chromium.org/1140913002/diff/1/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/1140913002/diff/1/cc/layers/layer_impl.cc#newcode659 cc/layers/layer_impl.cc:659: result->SetString("Layer", base::StringPrintf("%p", this)); What does the pointer do for ...
5 years, 7 months ago (2015-05-13 16:50:05 UTC) #3
r.kasibhatla
On 2015/05/13 at 16:50:05, danakj wrote: > https://codereview.chromium.org/1140913002/diff/1/cc/layers/layer_impl.cc > File cc/layers/layer_impl.cc (right): > > https://codereview.chromium.org/1140913002/diff/1/cc/layers/layer_impl.cc#newcode659 ...
5 years, 7 months ago (2015-05-14 03:51:56 UTC) #4
danakj
On Wed, May 13, 2015 at 8:51 PM, <r.kasibhatla@samsung.com> wrote: > On 2015/05/13 at 16:50:05, ...
5 years, 7 months ago (2015-05-14 16:52:49 UTC) #5
r.kasibhatla
On 2015/05/14 at 16:52:49, danakj wrote: > On Wed, May 13, 2015 at 8:51 PM, ...
5 years, 7 months ago (2015-05-15 04:45:16 UTC) #6
r.kasibhatla
@danakj: Removed the pointer info from json. Can you please stamp the change? Thanks :)
5 years, 7 months ago (2015-05-15 04:47:51 UTC) #7
danakj
LGTM
5 years, 7 months ago (2015-05-15 17:18:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140913002/20001
5 years, 7 months ago (2015-05-17 09:59:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-17 11:12:15 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd17d0e9e5ca003cb323c30225681f5719fc64db
Cr-Commit-Position: refs/heads/master@{#330306}

Powered by Google App Engine
This is Rietveld 408576698