Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 11409002: ES6: Add support for Set and Map clear method (Closed)

Created:
8 years, 1 month ago by arv (Not doing code reviews)
Modified:
8 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

ES6: Add support for Set and Map clear method http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts, section 15.14.5.3 and 15.14.5.2 BUG=v8:2400 Committed: https://code.google.com/p/v8/source/detail?r=12909

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M src/collection.js View 4 chunks +24 lines, -2 lines 2 comments Download
M test/mjsunit/harmony/collections.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/11409002/diff/1/src/collection.js File src/collection.js (right): https://codereview.chromium.org/11409002/diff/1/src/collection.js#newcode106 src/collection.js:106: %SetInitialize(this); I first added a %SetClear before I realized ...
8 years, 1 month ago (2012-11-08 21:16:28 UTC) #1
Michael Starzinger
8 years, 1 month ago (2012-11-09 08:56:12 UTC) #2
LGTM. I'll land that for you.

https://codereview.chromium.org/11409002/diff/1/src/collection.js
File src/collection.js (right):

https://codereview.chromium.org/11409002/diff/1/src/collection.js#newcode106
src/collection.js:106: %SetInitialize(this);
On 2012/11/08 21:16:28, arv wrote:
> I first added a %SetClear before I realized that it would do exactly the same
as
> %SetInitialize. It might be less confusing to have SetClear? WDYT?

That's fine, I prefer it the way it is as well. The less entry points into the
runtime the better. Should we start optimizing these entry points it's much
simpler that way.

Powered by Google App Engine
This is Rietveld 408576698