Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 11409: Translate volume information passed to the instance of Windows media player... (Closed)

Created:
12 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Translate volume information passed to the instance of Windows media player instantiated by the Activex shim. The Activex shim gets instantiated as a NPAPI plugin, which hosts the Media player activex. Volume defaults differ between the media player NPAPI plugin and the Activex. Fixes bug http://code.google.com/p/chromium/issues/detail?id=1163 R=amit Bug=1163 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5563

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M webkit/activex_shim/activex_plugin.cc View 1 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
12 years, 1 month ago (2008-11-17 18:27:20 UTC) #1
amit
http://codereview.chromium.org/11409/diff/1/2 File webkit/activex_shim/activex_plugin.cc (right): http://codereview.chromium.org/11409/diff/1/2#newcode119 Line 119: } Doesn't the volume need to be translated ...
12 years, 1 month ago (2008-11-17 18:42:37 UTC) #2
ananta
Done. Please take another look. Thanks Ananta On 2008/11/17 18:42:37, amit wrote: > http://codereview.chromium.org/11409/diff/1/2 > ...
12 years, 1 month ago (2008-11-17 18:53:22 UTC) #3
amit
12 years, 1 month ago (2008-11-17 18:54:58 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698