Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1140883003: [turbofan] Use frame state before for shift operations as well. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use frame state before for shift operations as well. This was already done for other binary operations, so it's basically copying the existing functionality to shift left and shift right logical/arithmetic. R=jarin@chromium.org Committed: https://crrev.com/5494920a1872aacfd8b83dc849952c98ae0e57e0 Cr-Commit-Position: refs/heads/master@{#28389}

Patch Set 1 #

Patch Set 2 : Add test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +10 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/deopt-tonumber-shift.js View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-13 07:48:22 UTC) #1
Benedikt Meurer
Hey Jaro, This is a trivial one. Please take a look (and hit CQ if ...
5 years, 7 months ago (2015-05-13 07:49:01 UTC) #2
Jarin
lgtm, deopt test would be nice.
5 years, 7 months ago (2015-05-13 07:58:18 UTC) #3
Benedikt Meurer
On 2015/05/13 07:58:18, jarin wrote: > lgtm, deopt test would be nice. Done.
5 years, 7 months ago (2015-05-13 10:48:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140883003/20001
5 years, 7 months ago (2015-05-13 10:49:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140883003/20001
5 years, 7 months ago (2015-05-13 11:15:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 11:17:34 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 11:17:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5494920a1872aacfd8b83dc849952c98ae0e57e0
Cr-Commit-Position: refs/heads/master@{#28389}

Powered by Google App Engine
This is Rietveld 408576698