Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1140873006: Add ONWERS files for preferences package. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ONWERS files for preferences package. The main preferences package already has an owners file, but the test package and the chrome shell preferences package don't. Committed: https://crrev.com/e3417c1e06cb80a5d1493e66a7f872297bd94e8f Cr-Commit-Position: refs/heads/master@{#330395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + chrome/android/javatests_shell/src/org/chromium/chrome/browser/preferences/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/preferences/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-18 17:52:21 UTC) #2
Ted C
lgtm
5 years, 7 months ago (2015-05-18 17:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140873006/1
5 years, 7 months ago (2015-05-18 18:09:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:19:23 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3417c1e06cb80a5d1493e66a7f872297bd94e8f
Cr-Commit-Position: refs/heads/master@{#330395}

Powered by Google App Engine
This is Rietveld 408576698