Push API: Avoid false positive DCHECK.

chrome/browser/push_messaging/push_messaging_app_identifier_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/push_messaging/push_messaging_app_identifier.h"
 
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 58 matching lines @@
   EXPECT_TRUE(GenerateId(GURL("https://www.example.com/"), -1).is_null());
 }
 
 TEST_F(PushMessagingAppIdentifierTest, UniqueGuids) {
   EXPECT_NE(PushMessagingAppIdentifier::Generate(
                 GURL("https://www.example.com/"), 1).app_id(),
             PushMessagingAppIdentifier::Generate(
                 GURL("https://www.example.com/"), 1).app_id());
 }
 
+TEST_F(PushMessagingAppIdentifierTest, FindInvalidAppId) {
+  // These calls to FindByAppId should not DCHECK.
+  EXPECT_TRUE(PushMessagingAppIdentifier::FindByAppId(profile(), "").is_null());
+  EXPECT_TRUE(PushMessagingAppIdentifier::FindByAppId(
+      profile(), "amhfneadkjmnlefnpidcijoldiibcdnd").is_null());
+}
+
 TEST_F(PushMessagingAppIdentifierTest, PersistAndFind) {
   ASSERT_TRUE(PushMessagingAppIdentifier::FindByAppId(
       profile(), original_.app_id()).is_null());
   ASSERT_TRUE(PushMessagingAppIdentifier::FindByServiceWorker(
       profile(), original_.origin(), original_.service_worker_registration_id())
           .is_null());
 
   // Test basic PersistToPrefs round trips.
   original_.PersistToPrefs(profile());
   {
@@ skipping 134 matching lines @@
       ExpectAppIdentifiersEqual(different_origin_, app_identifier);
       contained_different_origin = true;
     } else {
       ExpectAppIdentifiersEqual(different_sw_, app_identifier);
       contained_different_sw = true;
     }
   }
   EXPECT_TRUE(contained_different_origin);
   EXPECT_TRUE(contained_different_sw);
 }