Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: ui/file_manager/file_manager/background/js/launcher_search.js

Issue 1140873002: Change queryId of launcherSearchProvider API to integer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove old TODO. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/externs/launcher_search_provider.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/background/js/launcher_search.js
diff --git a/ui/file_manager/file_manager/background/js/launcher_search.js b/ui/file_manager/file_manager/background/js/launcher_search.js
index d64fe25f00fdc8a8bbe549347a9a179cda0b3e8c..7806f9b7fd9698e8c5fb9d0a6b25503a24cdcfaf 100644
--- a/ui/file_manager/file_manager/background/js/launcher_search.js
+++ b/ui/file_manager/file_manager/background/js/launcher_search.js
@@ -14,7 +14,7 @@ function LauncherSearch() {
/**
* Active query id. This value is set null when there is no active query.
- * @private {?string}
+ * @private {?number}
*/
this.queryId_ = null;
@@ -25,12 +25,12 @@ function LauncherSearch() {
this.enabled_ = false;
/**
- * @private {function(string, string, number)}
+ * @private {function(number, string, number)}
*/
this.onQueryStartedBound_ = this.onQueryStarted_.bind(this);
/**
- * @private {function(string)}
+ * @private {function(number)}
*/
this.onQueryEndedBound_ = this.onQueryEnded_.bind(this);
@@ -98,7 +98,7 @@ LauncherSearch.prototype.initializeEventListeners_ = function(isDriveEnabled) {
/**
* Handles onQueryStarted event.
- * @param {string} queryId
+ * @param {number} queryId
* @param {string} query
* @param {number} limit
*/
@@ -141,7 +141,7 @@ LauncherSearch.prototype.onQueryStarted_ = function(queryId, query, limit) {
/**
* Handles onQueryEnded event.
- * @param {string} queryId
+ * @param {number} queryId
*/
LauncherSearch.prototype.onQueryEnded_ = function(queryId) {
this.queryId_ = null;
« no previous file with comments | « ui/file_manager/externs/launcher_search_provider.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698