Change queryId of launcherSearchProvider API to integer.

chrome/browser/chromeos/launcher_search_provider/service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/launcher_search_provider/service.h"
 
 #include "base/memory/scoped_vector.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/launcher_search_provider/service_factory.h"
 #include "chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h"
@@ skipping 36 matching lines @@
 
   ++query_id_;
 
   extensions::EventRouter* event_router =
       extensions::EventRouter::Get(profile_);
 
   std::set<ExtensionId> extension_ids = GetListenerExtensionIds();
   for (const ExtensionId extension_id : extension_ids) {
     // Convert query_id_ to string here since queryId is defined as string in
     // javascript side API while we use uint32 internally to generate it.
     // TODO(yawano): Consider if we can change it to integer at javascript side.

[Matt Giuca, 2015/05/14 00:56:07]

Remove this comment.

[yawano, 2015/05/14 04:08:45]

Thank you! I forgot to remove this.

     event_router->DispatchEventToExtension(
         extension_id,
         make_scoped_ptr(new extensions::Event(
             api_launcher_search_provider::OnQueryStarted::kEventName,
             api_launcher_search_provider::OnQueryStarted::Create(
-                std::to_string(query_id_), query, max_result))));
+                query_id_, query, max_result))));
   }
 }
 
 void Service::OnQueryEnded() {
   DCHECK(is_query_running_);
   provider_ = nullptr;
 
   extensions::EventRouter* event_router =
       extensions::EventRouter::Get(profile_);
 
   std::set<ExtensionId> extension_ids = GetListenerExtensionIds();
   for (const ExtensionId extension_id : extension_ids) {
     event_router->DispatchEventToExtension(
         extension_id,
         make_scoped_ptr(new extensions::Event(
             api_launcher_search_provider::OnQueryEnded::kEventName,
-            api_launcher_search_provider::OnQueryEnded::Create(
-                std::to_string(query_id_)))));
+            api_launcher_search_provider::OnQueryEnded::Create(query_id_))));
   }
 
   is_query_running_ = false;
 }
 
 void Service::OnOpenResult(const ExtensionId& extension_id,
                            const std::string& item_id) {
   CHECK(ContainsValue(GetListenerExtensionIds(), extension_id));
 
   extensions::EventRouter* event_router =
       extensions::EventRouter::Get(profile_);
   event_router->DispatchEventToExtension(
       extension_id,
       make_scoped_ptr(new extensions::Event(
           api_launcher_search_provider::OnOpenResult::kEventName,
           api_launcher_search_provider::OnOpenResult::Create(item_id))));
 }
 
 void Service::SetSearchResults(
     const extensions::Extension* extension,
     scoped_ptr<ErrorReporter> error_reporter,
-    const std::string& query_id,
+    const int query_id,
     const std::vector<linked_ptr<
         extensions::api::launcher_search_provider::SearchResult>>& results) {
   // If query is not running or query_id is different from current query id,
   // discard the results.
-  if (!is_query_running_ || query_id != std::to_string(query_id_))
+  if (!is_query_running_ || query_id != query_id_)
     return;
 
   // If |extension| is not in the listener extensions list, ignore it.
   if (!ContainsValue(GetListenerExtensionIds(), extension->id()))
     return;
 
   // Set search results to provider.
   DCHECK(provider_);
   ScopedVector<app_list::LauncherSearchResult> search_results;
   for (const auto& result : results) {
@@ skipping 28 matching lines @@
         extensions::APIPermission::kLauncherSearchProvider);
     if (has_permission)
       extension_ids.insert(extension->id());
   }
 
   return extension_ids;
 }
 
 }  // namespace launcher_search_provider
 }  // namespace chromeos