Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1140863002: Inline zoom level to zoom factor conversion in event sender (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline zoom level to zoom factor conversion in event sender The goal is to remove all dependencies from test_runner on content BUG=478250 R=mkwst@chromium.org Committed: https://crrev.com/7fa003731696fb199d7a7bdb40e5957f4e2bbba1 Cr-Commit-Position: refs/heads/master@{#329602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/shell/renderer/test_runner/event_sender.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-13 06:05:16 UTC) #1
Mike West
LGTM.
5 years, 7 months ago (2015-05-13 07:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140863002/1
5 years, 7 months ago (2015-05-13 07:10:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 07:13:44 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 07:14:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fa003731696fb199d7a7bdb40e5957f4e2bbba1
Cr-Commit-Position: refs/heads/master@{#329602}

Powered by Google App Engine
This is Rietveld 408576698