Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1140833002: Describe required properties of public/ files with a README. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Describe required properties of public/ files with a README. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e6bd866c5c64950a8b2836e7254e1f44b2fe0925

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A public/README View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, text-only CL.
5 years, 7 months ago (2015-05-12 21:48:13 UTC) #2
Lei Zhang
https://codereview.chromium.org/1140833002/diff/1/public/README File public/README (right): https://codereview.chromium.org/1140833002/diff/1/public/README#newcode5 public/README:5: beyond what is present here, then a new API ...
5 years, 7 months ago (2015-05-12 21:52:07 UTC) #3
Lei Zhang
Otherwise lgtm
5 years, 7 months ago (2015-05-12 21:52:20 UTC) #4
Tom Sepez
https://codereview.chromium.org/1140833002/diff/1/public/README File public/README (right): https://codereview.chromium.org/1140833002/diff/1/public/README#newcode5 public/README:5: beyond what is present here, then a new API ...
5 years, 7 months ago (2015-05-12 22:44:17 UTC) #5
Tom Sepez
5 years, 7 months ago (2015-05-12 22:44:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e6bd866c5c64950a8b2836e7254e1f44b2fe0925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698