Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1140823007: Revert of Move token handle obtaining to UserSessionManager (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move token handle obtaining to UserSessionManager (patchset #1 id:1 of https://codereview.chromium.org/1129293004/) Reason for revert: most likely culprit for interactive ui test failures here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2847 Original issue's description: > Move token handle obtaining to UserSessionManager > > BUG=484690, 484734 > R=nkostylev@chromium.org > > Committed: https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9 > Cr-Commit-Position: refs/heads/master@{#329868} TBR=nkostylev@chromium.org,antrim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484690, 484734 Committed: https://crrev.com/55c68a9a9aecbdc22fd06a99aa93b98881405d88 Cr-Commit-Position: refs/heads/master@{#329891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -49 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +31 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
Created Revert of Move token handle obtaining to UserSessionManager
5 years, 7 months ago (2015-05-14 19:00:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140823007/1
5 years, 7 months ago (2015-05-14 19:02:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 19:08:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55c68a9a9aecbdc22fd06a99aa93b98881405d88 Cr-Commit-Position: refs/heads/master@{#329891}
5 years, 7 months ago (2015-05-14 19:09:55 UTC) #4
Evan Stade
5 years, 7 months ago (2015-05-14 19:45:05 UTC) #5
Message was sent while issue was closed.
On 2015/05/14 19:09:55, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/55c68a9a9aecbdc22fd06a99aa93b98881405d88
> Cr-Commit-Position: refs/heads/master@{#329891}

also broken: OobeSuite_OobeTest.NewUser

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Powered by Google App Engine
This is Rietveld 408576698