Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: third_party/closure_compiler/compiler_customization_test.py

Issue 1140823005: Fix compiler_customization_test.py by including polymer externs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/compiler_customization_test.py
diff --git a/third_party/closure_compiler/compiler_customization_test.py b/third_party/closure_compiler/compiler_customization_test.py
index 8092ecd524d8d5e6e30ac91e56e86508d0a27079..9873c8fe6c9018b8b19649ae7183a4f432108db9 100755
--- a/third_party/closure_compiler/compiler_customization_test.py
+++ b/third_party/closure_compiler/compiler_customization_test.py
@@ -16,6 +16,9 @@ _RESOURCES_DIR = os.path.join(_SRC_DIR, "ui", "webui", "resources", "js")
_ASSERT_JS = os.path.join(_RESOURCES_DIR, "assert.js")
_CR_JS = os.path.join(_RESOURCES_DIR, "cr.js")
_CR_UI_JS = os.path.join(_RESOURCES_DIR, "cr", "ui.js")
+_POLYMER_EXTERNS = os.path.join(_SRC_DIR, "third_party", "polymer", "v0_8",
+ "components-chromium", "polymer-externs",
+ "polymer.externs.js")
class CompilerCustomizationTest(unittest.TestCase):
@@ -29,7 +32,7 @@ class CompilerCustomizationTest(unittest.TestCase):
def _runChecker(self, source_code):
file_path = "/script.js"
FileCache._cache[file_path] = source_code
- return self._checker.check(file_path)
+ return self._checker.check(file_path, externs=[_POLYMER_EXTERNS])
def _runCheckerTestExpectError(self, source_code, expected_error):
_, stderr = self._runChecker(source_code)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698