Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1140823005: Fix compiler_customization_test.py by including polymer externs (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compiler_customization_test.py by including polymer externs BUG= NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/795f2d661c9b9aa3e14116c711ab51086c152f32 Cr-Commit-Position: refs/heads/master@{#329515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/closure_compiler/compiler_customization_test.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-12 21:57:00 UTC) #2
Dan Beam
lgtm
5 years, 7 months ago (2015-05-12 22:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140823005/1
5 years, 7 months ago (2015-05-12 22:13:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 22:27:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:28:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/795f2d661c9b9aa3e14116c711ab51086c152f32
Cr-Commit-Position: refs/heads/master@{#329515}

Powered by Google App Engine
This is Rietveld 408576698