Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 1140813007: Fix cluster-fuzz crash with internal EventSender API. (Closed)

Created:
5 years, 7 months ago by dtapuska
Modified:
5 years, 7 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cluster-fuzz crash with internal EventSender API. In release mode a DCHECK was compiled out and caused a crash; it was correctly asserting in the Debug builds. Change the DCHECK into a runtime check that throws an exception. This addresses the cluster fuzz crash. BUG=472058 TEST=out/Release/content_shell --dump-render-tree --use-gl=any --disable-gl-drawing-for-test file:///work/issues/472058/test.html Committed: https://crrev.com/bd2a165a1018ec23d060b72b29af7fe26e5f1828 Cr-Commit-Position: refs/heads/master@{#330659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dtapuska
5 years, 7 months ago (2015-05-19 14:56:51 UTC) #2
Rick Byers
What does your TEST= line refer to, just some local file you were using for ...
5 years, 7 months ago (2015-05-19 22:39:54 UTC) #3
dtapuska
On 2015/05/19 22:39:54, Rick Byers wrote: > What does your TEST= line refer to, just ...
5 years, 7 months ago (2015-05-19 22:51:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813007/1
5 years, 7 months ago (2015-05-19 22:53:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 00:30:22 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:31:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd2a165a1018ec23d060b72b29af7fe26e5f1828
Cr-Commit-Position: refs/heads/master@{#330659}

Powered by Google App Engine
This is Rietveld 408576698