Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140813005: Fix RenderWidgetHostViewAuraTest failure on devices with little memory (Closed)

Created:
5 years, 7 months ago by halliwell
Modified:
5 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RenderWidgetHostViewAuraTest failure on devices with little memory This test fails (same symptoms as bug 443352) on hardware with <= 256MB of RAM. BUG= internal b/21093117 Committed: https://crrev.com/b655f88a4071489d7c019ee382c8a9ad131b3259 Cr-Commit-Position: refs/heads/master@{#330541}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alternative approach so test actually runs and works on low memory hardware #

Patch Set 3 : Remove unnecessary include #

Total comments: 1

Patch Set 4 : A nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/renderer_host/renderer_frame_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
halliwell
5 years, 7 months ago (2015-05-15 23:45:33 UTC) #2
danakj
https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode2053 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:2053: if (base::SysInfo::AmountOfPhysicalMemoryMB() <= 256) Can you instead mock out/inject ...
5 years, 7 months ago (2015-05-15 23:55:13 UTC) #4
halliwell
https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode2053 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:2053: if (base::SysInfo::AmountOfPhysicalMemoryMB() <= 256) On 2015/05/15 23:55:13, danakj wrote: ...
5 years, 7 months ago (2015-05-16 00:11:18 UTC) #5
halliwell
On 2015/05/16 00:11:18, halliwell wrote: > https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc > File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc > (right): > > https://codereview.chromium.org/1140813005/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode2053 ...
5 years, 7 months ago (2015-05-18 16:48:44 UTC) #6
danakj
LGTM https://codereview.chromium.org/1140813005/diff/40001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/1140813005/diff/40001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode2054 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:2054: const size_t max_renderer_frames = 5; nit: no const, ...
5 years, 7 months ago (2015-05-18 17:14:50 UTC) #7
Mr4D (OOO till 08-26)
lgtm
5 years, 7 months ago (2015-05-18 20:13:52 UTC) #8
sadrul
rs lgtm
5 years, 7 months ago (2015-05-19 04:07:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813005/60001
5 years, 7 months ago (2015-05-19 14:41:22 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-19 17:17:10 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:18:45 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b655f88a4071489d7c019ee382c8a9ad131b3259
Cr-Commit-Position: refs/heads/master@{#330541}

Powered by Google App Engine
This is Rietveld 408576698