NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions

chrome/browser/resources/history/other_devices.js

Index: chrome/browser/resources/history/other_devices.js
diff --git a/chrome/browser/resources/history/other_devices.js b/chrome/browser/resources/history/other_devices.js
index 3ac878ef774ad4301d4eb104f570bd44562d00a0..acd21b65df771efebe6d97f4dab124fa660b546c 100644
--- a/chrome/browser/resources/history/other_devices.js
+++ b/chrome/browser/resources/history/other_devices.js
@@ -14,7 +14,6 @@
 /** @const */ var NB_ENTRIES_OTHER_ROWS_COLUMN = 0;
 
 // Histogram buckets for UMA tracking of menu usage.
-// Using the same values as the Other Devices button in the NTP.
 /** @const */ var HISTOGRAM_EVENT = {
   INITIALIZED: 0,
   SHOW_MENU: 1,
@@ -43,10 +42,6 @@ function recordUmaEvent_(eventId) {
 
 /**
  * Controller for the context menu for device names in the list of sessions.
- * This class is designed to be used as a singleton. Also copied from existing
- * other devices button in NTP.
- * TODO(mad): Should we extract/reuse/share with ntp4/other_sessions.js?
- *
  * @constructor
  */
 function DeviceContextMenuController() {
@@ -562,11 +557,9 @@ function load() {
   if (!loadTimeData.getBoolean('isInstantExtendedApiEnabled'))
     return;
 
-  // We must use this namespace to reuse the handler code for foreign session
-  // and login.
+  // TODO(dbeam): why is the ntp.* namespace being used from the history page?

[Evan Stade, 2015/05/18 18:28:59]

doesn't the old comment answer that question for you?

[Dan Beam, 2015/05/18 18:38:15]

i disagree with the original comment.  nothing about this code "must use this
namespace".  it just wasn't changed to be shared.

[Evan Stade, 2015/05/18 18:49:07]

It doesn't have to make sense to answer the question of why it's being done.

You should leave the comment and add a TODO under it:
// TODO(dbeam): change the call site in foobar.cc so this hack isn't necessary.

[Dan Beam, 2015/05/18 20:00:34]

Done.

   cr.define('ntp', function() {
     return {
-      setForeignSessions: setForeignSessions,
       updateLogin: updateLogin
     };
   });