Chromium Code Reviews Chromium Code Reviews
Issue 1140813003:
NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@suggestions-page| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 14d41d682945abe6b189d1338bb528443b3315c4..4c9954390e56b86b7a2b451c2d9397a1ec6bdcf6 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -4484,16 +4484,6 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| -<histogram name="DataReductionProxy.SecureProxyCheck.Latency" |
| - units="milliseconds"> |
| - <owner>jeremyim@chromium.org</owner> |
| - <owner>bengr@chromium.org</owner> |
| - <summary> |
| - Time from when the Data Reduction Proxy secure proxy check starts until it |
| - completes. |
| - </summary> |
| -</histogram> |
| - |
| <histogram name="DataReductionProxy.ResponseProxyServerStatus" |
| enum="DataReductionProxyResponseProxyServerStatus"> |
| <owner>sclittle@chromium.org</owner> |
| @@ -4504,6 +4494,16 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="DataReductionProxy.SecureProxyCheck.Latency" |
|
Mark P
2015/05/15 23:19:39
Please rebase; I think this change will go away.
Dan Beam
2015/05/15 23:38:52
Done.
|
| + units="milliseconds"> |
| + <owner>jeremyim@chromium.org</owner> |
| + <owner>bengr@chromium.org</owner> |
| + <summary> |
| + Time from when the Data Reduction Proxy secure proxy check starts until it |
| + completes. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DataReductionProxy.SettingsConversion" |
| enum="DataReductionProxySettingsConversion"> |
| <obsolete> |
| @@ -12492,7 +12492,7 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| -<histogram name="HistoryPage.OtherDevicesMenu" enum="NtpOtherSessionsType"> |
| +<histogram name="HistoryPage.OtherDevicesMenu" enum="HistoryOtherDevicesType"> |
|
Mark P
2015/05/15 23:19:39
Is this merely a name of the enum?
Dan Beam
2015/05/15 23:38:52
yep. assuming you don't want this change: reverte
Dan Beam
2015/05/16 00:10:12
Renamed as per IM convo.
|
| <owner>mad@chromium.org</owner> |
| <owner>rpop@google.com</owner> |
| <summary> |
| @@ -25033,14 +25033,6 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| -<histogram name="NewTabPage.OtherSessionsMenu" enum="NtpOtherSessionsType"> |
|
Mark P
2015/05/15 23:19:39
Never delete old histograms; instead mark them obs
Dan Beam
2015/05/15 23:38:52
Done.
|
| - <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| - <summary> |
| - Histogram for usage of the menu on the NTP that allows the user to access |
| - tabs from other devices. |
| - </summary> |
| -</histogram> |
| - |
| <histogram name="NewTabPage.PreviousSelectedPageType" enum="NtpPaneType"> |
| <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| <summary> |
| @@ -54633,6 +54625,18 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </int> |
| </enum> |
| +<enum name="HistoryOtherDevicesType" type="int"> |
| + <int value="0" label="Menu initialized"/> |
| + <int value="1" label="Menu shown"/> |
| + <int value="2" label="Link clicked"/> |
| + <int value="3" label="Link context menu shown"/> |
| + <int value="4" label="Device context menu shown"/> |
| + <int value="5" label="Unused/previous device context menu shown"/> |
| + <int value="6" label="Collapse Session"/> |
| + <int value="7" label="Expand Session"/> |
| + <int value="8" label="Open All"/> |
| +</enum> |
| + |
| <enum name="HistoryTopSitesRecoveryEnum" type="int"> |
| <summary>Error states noted in top_sites_database.cc recovery code.</summary> |
| <int value="0" label="RECOVERY_EVENT_RECOVERED">Successful recovery.</int> |
| @@ -58877,18 +58881,6 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="13" label="Other action"/> |
| </enum> |
| -<enum name="NtpOtherSessionsType" type="int"> |
| - <int value="0" label="Menu initialized"/> |
| - <int value="1" label="Menu shown"/> |
| - <int value="2" label="Link clicked"/> |
| - <int value="3" label="Link context menu shown"/> |
| - <int value="4" label="Device context menu shown"/> |
| - <int value="5" label="Unused/previous device context menu shown"/> |
| - <int value="6" label="Collapse Session"/> |
| - <int value="7" label="Expand Session"/> |
| - <int value="8" label="Open All"/> |
| -</enum> |
| - |
| <enum name="NtpPaneType" type="int"> |
| <int value="1" label="MostVisited"/> |
| <int value="2" label="Apps"/> |
