Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: chrome/browser/resources/history/other_devices.js

Issue 1140813003: NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@suggestions-page
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/ntp4/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/other_devices.js
diff --git a/chrome/browser/resources/history/other_devices.js b/chrome/browser/resources/history/other_devices.js
index 3ac878ef774ad4301d4eb104f570bd44562d00a0..3f29ca7ca46353f2863bde8cc9ac3e66a1931e48 100644
--- a/chrome/browser/resources/history/other_devices.js
+++ b/chrome/browser/resources/history/other_devices.js
@@ -14,7 +14,6 @@
/** @const */ var NB_ENTRIES_OTHER_ROWS_COLUMN = 0;
// Histogram buckets for UMA tracking of menu usage.
-// Using the same values as the Other Devices button in the NTP.
/** @const */ var HISTOGRAM_EVENT = {
INITIALIZED: 0,
SHOW_MENU: 1,
@@ -43,10 +42,6 @@ function recordUmaEvent_(eventId) {
/**
* Controller for the context menu for device names in the list of sessions.
- * This class is designed to be used as a singleton. Also copied from existing
- * other devices button in NTP.
- * TODO(mad): Should we extract/reuse/share with ntp4/other_sessions.js?
- *
* @constructor
*/
function DeviceContextMenuController() {
@@ -563,10 +558,10 @@ function load() {
return;
// We must use this namespace to reuse the handler code for foreign session
- // and login.
+ // and login. TODO(estade): change the call site in ntp_login_handler.cc so
+ // this hack isn't necessary.
cr.define('ntp', function() {
return {
- setForeignSessions: setForeignSessions,
updateLogin: updateLogin
};
});
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/resources/ntp4/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698