Make channel mixing checks explicit.

Make channel mixing checks explicit.

The existing checks were not strong enough and would pass
through certain up mixing situations which are not supported.

BUG=159924
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166714

[DaleCurtis, 2012-11-08 01:31:49]

Henrik, PTAL. This is a commit directly into M23 branch. Haven't tested yet
since I'm on my macbook remotely today.

[henrika (OOO until Aug 14), 2012-11-08 08:27:36]

LGTM.

Just checking. This will only affect M23 and not M24 or later. Correct?

[henrika (OOO until Aug 14), 2012-11-08 08:27:42]

https://codereview.chromium.org/11408002/diff/1/audio_low_latency_output_win.cc
File audio_low_latency_output_win.cc (right):

https://codereview.chromium.org/11408002/diff/1/audio_low_latency_output_win....
audio_low_latency_output_win.cc:506: if (format_.Format.nChannels !=
client_channel_count_ &&
We could perhaps keep some comments. You removed them all.

[DaleCurtis, 2012-11-08 18:39:30]

Committed.

https://codereview.chromium.org/11408002/diff/1/audio_low_latency_output_win.cc
File audio_low_latency_output_win.cc (right):

https://codereview.chromium.org/11408002/diff/1/audio_low_latency_output_win....
audio_low_latency_output_win.cc:506: if (format_.Format.nChannels !=
client_channel_count_ &&
On 2012/11/08 08:27:42, henrika wrote:
> We could perhaps keep some comments. You removed them all.

The old ones are out of date and the LOG(ERROR) explains what the check is
doing.