Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1140783002: Surface test times of android tests. (Closed)

Created:
5 years, 7 months ago by shatch
Modified:
5 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, fmeawad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Surface test times of android tests. Right now we have no easy visibility on time taken for individual tests, since everything runs under one massive "Sharded Perf Tests" step. We're trying to balance the tests across devices to improve cycle time, so we need a way to see how long each test is actually taking. BUG=466101 Committed: https://crrev.com/8a9efca9b5451c75da244f62f073206c97ef6dd4 Cr-Commit-Position: refs/heads/master@{#329722}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Leave out total_time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M build/android/pylib/perf/test_runner.py View 1 2 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
shatch
5 years, 7 months ago (2015-05-12 20:04:12 UTC) #2
Sami
lgtm. https://codereview.chromium.org/1140783002/diff/1/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/1140783002/diff/1/build/android/pylib/perf/test_runner.py#newcode87 build/android/pylib/perf/test_runner.py:87: 'total_time': -1} Not sure if it makes more ...
5 years, 7 months ago (2015-05-13 18:39:19 UTC) #3
shatch
On 2015/05/13 18:39:19, Sami wrote: > lgtm. > > https://codereview.chromium.org/1140783002/diff/1/build/android/pylib/perf/test_runner.py > File build/android/pylib/perf/test_runner.py (right): > ...
5 years, 7 months ago (2015-05-13 19:07:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140783002/20001
5 years, 7 months ago (2015-05-13 19:09:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 22:00:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:02:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a9efca9b5451c75da244f62f073206c97ef6dd4
Cr-Commit-Position: refs/heads/master@{#329722}

Powered by Google App Engine
This is Rietveld 408576698