src/compiler/js-inlining.cc - Issue 1140743004: Generalize builtins inlining flag to allow forced inlining of any function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-inlining.cc

Issue 1140743004: Generalize builtins inlining flag to allow forced inlining of any function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-inlining.cc

diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc

index 66d71a6e298daf623d612a0f511f6881bb90baec..de0ccb6e94e71d246bce2a50ef4b6384532a889f 100644

--- a/src/compiler/js-inlining.cc

+++ b/src/compiler/js-inlining.cc

@@ -295,7 +295,7 @@ Reduction JSInliner::Reduce(Node* node) {

Handle<JSFunction> function = match.Value().handle();

if (!function->IsJSFunction()) return NoChange();

- if (mode_ == kBuiltinsInlining && !function->shared()->inline_builtin()) {

+ if (mode_ == kRestrictedInlining && !function->shared()->force_inline()) {

return NoChange();

}

« no previous file with comments | « src/compiler/js-inlining.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »